fix(lsp): find_completion_range off-by-one
#11266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RoloEdits
force-pushed
the
fix-lsp-range-oob
branch
from
f85186f
to
21eb32e
Compare
There was a problem hiding this comment.
Instead I think we should cap end to text.len_chars() in find_completion_range in the if replace_mode block. @pascalkuthe might have more context for this change though
|
This is not a python bug but a bugnwith our code. I knew of this for a whole but I thought I (or something else) already fried it. This is however not the right fix for the issue. This was a logic bug introduced by me into this block: Line 285 in 21eb32e Both the |
pascalkuthe
added
S-waiting-on-author
RoloEdits
force-pushed
the
fix-lsp-range-oob
branch
from
21eb32e
to
72553b2
Compare
RoloEdits
changed the title
find_completion_range off-by-one
pascalkuthe
approved these changes
Jul 24, 2024
the-mikedavis
approved these changes
Jul 24, 2024
SofusA
pushed a commit
to SofusA/helix-pull-diagnostics
that referenced
this pull request
Aug 4, 2024
mxxntype
pushed a commit
to mxxntype/helix
that referenced
this pull request
Aug 14, 2024
stackotter
pushed a commit
to stackotter/helix
that referenced
this pull request
Aug 28, 2024
kyruzic
pushed a commit
to kyruzic/helix
that referenced
this pull request
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an off-by-one error that caused index out of bounds for some LSP responses, or the eating of newlines for others.
Fixes: #10689