Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document scrolling for hover command in keymap.md #1117

Merged
merged 2 commits into from
Nov 19, 2021

Conversation

s1ck
Copy link
Contributor

@s1ck s1ck commented Nov 17, 2021

I was under the impression that scrolling does not work for the hover command.
I started digging in the source to figure out how to add it.
Ended up disovering the Popup struct and its scroll method, followed the refs and found the shortcuts :)

To save some time for others, I added the info to the keymap.md.

@s1ck s1ck force-pushed the improve-keymap-hover-command branch from de9eb50 to 4ce7524 Compare November 17, 2021 12:05
@s1ck s1ck force-pushed the improve-keymap-hover-command branch from 4ce7524 to e14fd8c Compare November 17, 2021 12:07
| ----- | ----------- | ------- |
| `f` | Open file picker | `file_picker` |
| `b` | Open buffer picker | `buffer_picker` |
| `k` | Show documentation for item under cursor, use `Ctrl-u` and `Ctrl-d` to scroll (**LSP**) | `hover` |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, I didn't know about this either but it should be kept in popup section. Here we can just redirect them to shortcuts.

Copy link
Contributor Author

@s1ck s1ck Nov 17, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mean to create a new Popup section in keymap.md and link to that one?

@archseer archseer merged commit f2b4ff2 into helix-editor:master Nov 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants