Document scrolling for hover command in keymap.md #1117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
s1ck
force-pushed
the
improve-keymap-hover-command
branch
from
de9eb50
to
4ce7524
Compare
s1ck
force-pushed
the
improve-keymap-hover-command
branch
from
4ce7524
to
e14fd8c
Compare
pickfire
reviewed
Nov 17, 2021
book/src/keymap.md
Outdated
| | ----- | ----------- | ------- | | ||
| | `f` | Open file picker | `file_picker` | | ||
| | `b` | Open buffer picker | `buffer_picker` | | ||
| | `k` | Show documentation for item under cursor, use `Ctrl-u` and `Ctrl-d` to scroll (**LSP**) | `hover` | |
There was a problem hiding this comment.
Nice, I didn't know about this either but it should be kept in popup section. Here we can just redirect them to shortcuts.
There was a problem hiding this comment.
Do you mean to create a new Popup section in keymap.md and link to that one?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was under the impression that scrolling does not work for the hover command.
I started digging in the source to figure out how to add it.
Ended up disovering the
Popupstruct and itsscrollmethod, followed the refs and found the shortcuts :)To save some time for others, I added the info to the keymap.md.