Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restore disabled grammars #11168

Closed
wants to merge 1 commit into from
Closed

Restore disabled grammars #11168

wants to merge 1 commit into from

Conversation

omasanori
Copy link
Contributor

This change reverts #9316, which disables grammars hosted on sr.ht. The outage of sr.ht on January 2024 had been addressed and its post-mortem was published on their blog.

@omasanori
Restore disabled grammars
e5cc569 
This change reverts <helix-editor#9316>,
which disables grammars hosted on sr.ht. The outage of sr.ht on January
2024 had been addressed and its post-mortem was published on their blog.

This reverts commit 17dd102.

Reference: https://sourcehut.org/blog/2024-01-19-outage-post-mortem/
@omasanori
Copy link
Contributor Author

Well I overlooked the user rename problem. I hope these languages are available in the next release but please reject this PR if the situation is still unsatisfied.

@pascalkuthe
Copy link
Member

The grammars were not disabled as a reaction to that particular outage. The post mortem is not a reason to revert.

We had issues with sourcehut hosted grammars for a long time. Both before this particular incident and after this particular post mortem was posted. Until recently we still got regular bug reports because people were trying to build a previous release where the grammars were not disabled and had build issues as sourcehut was apparently down. That only stopped because everybody has migrated to 24.3/24.7 now where the grammars are disabled by default

@omasanori
Copy link
Contributor Author

Thank you for your explanation, @pascalkuthe! Then,

I would be in favor of some sort of mirror eventually

I agree with this. Closing.

@omasanori omasanori closed this Jul 15, 2024
@omasanori omasanori deleted the restore-srht-grammars branch July 15, 2024 01:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@omasanori @pascalkuthe