Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Hare grammar #11130

Merged
merged 1 commit into from
Jul 13, 2024
Merged

Update Hare grammar #11130

merged 1 commit into from
Jul 13, 2024

Conversation

omasanori
Copy link
Contributor

@omasanori omasanori commented Jul 11, 2024 •
edited
Loading

This change uses https://git.sr.ht/~ecs/tree-sitter-hare/ that is up-to-date and linked from the official documentation.

@omasanori omasanori marked this pull request as draft July 11, 2024 02:03
@omasanori
Copy link
Contributor Author

~ecs/tree-sitter-hare makes syntax highlighting disabled for unknown reasons.

@archseer
Copy link
Member

Quite likely you need to also update the highlight queries besides just updating an URL

@omasanori
Update Hare grammar
3583fd1 
This change uses <https://git.sr.ht/~ecs/tree-sitter-hare/> that is
up-to-date and linked from the official documentation.
@omasanori omasanori changed the title Update hare grammer location Update Hare grammar Jul 11, 2024
@omasanori omasanori marked this pull request as ready for review July 11, 2024 20:41
@omasanori
Copy link
Contributor Author

highlights.scm and locals.scm has been adjusted to the new grammar and now cargo xtask query-check passes. Here is a screenshot (code quoted from the official website):

Screenshot from 2024-07-12 19-18-30

@the-mikedavis the-mikedavis added the A-language-support Area: Support for programming/text languages label Jul 12, 2024
@archseer archseer merged commit ec0bdb3 into helix-editor:master Jul 13, 2024
6 checks passed
@omasanori omasanori deleted the patch-1 branch July 13, 2024 21:22
mxxntype pushed a commit to mxxntype/helix that referenced this pull request Aug 14, 2024
@omasanori @mxxntype
Update Hare grammar (helix-editor#11130)
bdc091b 
This change uses <https://git.sr.ht/~ecs/tree-sitter-hare/> that is
up-to-date and linked from the official documentation.
kyruzic pushed a commit to kyruzic/helix that referenced this pull request Sep 27, 2024
@omasanori @kyruzic
Update Hare grammar (helix-editor#11130)
59befc6 
This change uses <https://git.sr.ht/~ecs/tree-sitter-hare/> that is
up-to-date and linked from the official documentation.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@the-mikedavis the-mikedavis the-mikedavis approved these changes

Assignees
No one assigned
Labels
A-language-support Area: Support for programming/text languages
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@omasanori @archseer @the-mikedavis