languages: add mdx to markdown filetypes #11122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the-mikedavis
approved these changes
Jul 10, 2024
the-mikedavis
added
the
A-language-support
|
Would be nice to have proper support that can highlight both markdown and Javascript. |
this is a great point. here's an example of the javascript imports not highlighting: |
|
This appears to be blocked on upstream tree-sitter-grammars/tree-sitter-markdown#81 |
|
seems like this needs a seperate mdx grammar to be solved which doens't exist yet... |
|
I will merge this for now since markdown is quite close for this file format and this cannot be resolved upstream or on our side |
pascalkuthe
approved these changes
Jul 25, 2024
SofusA
pushed a commit
to SofusA/helix-pull-diagnostics
that referenced
this pull request
Aug 4, 2024
mxxntype
pushed a commit
to mxxntype/helix
that referenced
this pull request
Aug 14, 2024
stackotter
pushed a commit
to stackotter/helix
that referenced
this pull request
Aug 28, 2024
kyruzic
pushed a commit
to kyruzic/helix
that referenced
this pull request
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mdx- markdown with jsx support is becoming quite popular for some react-based javascript frameworksthe standard markdown highlighting works fine