Gruvbox light theme. Fix cursorline readability after #10773. #11071
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smortime
pushed a commit
to smortime/helix
that referenced
this pull request
Jul 10, 2024
mxxntype
pushed a commit
to mxxntype/helix
that referenced
this pull request
Aug 14, 2024
kyruzic
pushed a commit
to kyruzic/helix
that referenced
this pull request
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Religious Gruvbox light user here. @Chirikumbrah recently made a number of excellent tweaks to the base Gruvbox theme (#10773). One of these has had the unfortunate effect of turning the non-primary cursor line dark, making the text of the current line unreadable due to poor contrast. This is shown in the 'before' panel of the image below.
This PR sets things right by overriding the non-primary cursor background in the Gruvbox Light variant (which propagates to the other Light variants through inheritance.) The result is shown in the 'after' panel.
Question for @Chirikumbrah: I see you've defined a special
bg0_s = "#32302f"(dark0_soft in gruvbox.nvim) for the cursorline. This is the same color as the background in Gruvbox Dark Soft, meaning that the non-primary cursorline doesn't appear when using that variant. Do you think we should a) drop bg0_s altogether or b) specify a separate"ui.cursorline"in the Dark Soft variant, so that it appears again? I ask because, if we keep bg0_s, it would probably be more consistent if I defined a separate bg0_s in the Light theme (light0_soft in gruvbox.nvim, to be specific).