Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only pluralise "buffer" when required #11018

Merged
merged 2 commits into from
Jun 26, 2024
Merged

Only pluralise "buffer" when required #11018

merged 2 commits into from
Jun 26, 2024

Conversation

thomasschafer
Copy link
Contributor

@thomasschafer thomasschafer commented Jun 22, 2024 •
edited
Loading

Rather than showing an error of n unsaved buffer(s) remaining: ..., we use either buffer or buffers as required.

@thomasschafer thomasschafer changed the title Only pluralise buffer when required Only pluralise "buffer" when required Jun 22, 2024
the-mikedavis
the-mikedavis reviewed Jun 26, 2024
View reviewed changes
Copy link
Member

@the-mikedavis the-mikedavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a tiny consistency nit - elsewhere where we conditionally add the 's' we always check == 1

helix-term/src/commands/typed.rs Outdated Show resolved Hide resolved
helix-term/src/commands/typed.rs Outdated Show resolved Hide resolved
@thomasschafer
Copy link
Contributor Author

Just a tiny consistency nit - elsewhere where we conditionally add the 's' we always check == 1

Sounds good - done

@pascalkuthe pascalkuthe merged commit 6ed0d0c into helix-editor:master Jun 26, 2024
6 checks passed
smortime pushed a commit to smortime/helix that referenced this pull request Jul 10, 2024
@thomasschafer
Only pluralise "buffer" when required (helix-editor#11018)
8e71795 
* Only pluralise buffer when required

* Use == 1 instead of != 1
mxxntype pushed a commit to mxxntype/helix that referenced this pull request Aug 14, 2024
@thomasschafer @mxxntype
Only pluralise "buffer" when required (helix-editor#11018)
5c0c23b 
* Only pluralise buffer when required

* Use == 1 instead of != 1
kyruzic pushed a commit to kyruzic/helix that referenced this pull request Sep 27, 2024
@thomasschafer @kyruzic
Only pluralise "buffer" when required (helix-editor#11018)
3ef7982 
* Only pluralise buffer when required

* Use == 1 instead of != 1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pascalkuthe pascalkuthe pascalkuthe approved these changes

@the-mikedavis the-mikedavis the-mikedavis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thomasschafer @the-mikedavis @pascalkuthe