-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Continue line comments #10996
Continue line comments #10996
Conversation
…n1991/helix into feature/continue-comment
…lix into continue-single-comment
57b449c
to
0fccc92
Compare
0fccc92
to
8fa3cc9
Compare
One thing which bothers me is how we want to "continue" the comment from block comments like for C of this style:
Should this be tackled in this PR or in another PR? Should this be tackled at all? |
Yeah good point, I hadn't thought to use C-w to remove the comment token. Kakoune's behavior for this is confusing and maybe buggy - enter sometimes strips the comment token but it depends on the language and context. Using C-w is more explicit and predictable and we should avoid ruining the experience of continuing a comment over multiple lines, for example adding an extra line to break up paragraphs in markdown in a Rust doc comment. For that use-case specifically I believe we also want to be trimming whitespace under certain conditions in |
Co-authored-by: Michael Davis <[email protected]>
5a2a96e
to
b7f9780
Compare
new_text.push_str(token); | ||
new_text.push(' '); | ||
new_text.chars().count() | ||
} else if on_auto_pair { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this is a limitation we want to have in thr lognterm but usually autopairs within comments are a bit niche and likely hard to fix until some other changss land so this is probably fine for now.
18d007a
to
12a8b3e
Compare
This just made my night. Thank you @TornaxO7 & rest of the maintainers 🙌🏾 🙌🏾 for the steady progress. |
Closes #1730
Continues #8664
This is my attempt to apply the changes of #4718 to the PR.