Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve jump colors for github_dark themes #10946

Merged
merged 1 commit into from
Jun 18, 2024

Conversation

merisbahti
Copy link
Contributor

The colors while using the newly introduced jump feature have been bugging me, especially in the github_dark family of themes.

Before

(I can hardly see this, especially the jump characters on selection)
image

After

image

the-mikedavis
the-mikedavis previously approved these changes Jun 13, 2024
@the-mikedavis the-mikedavis added the A-theme Area: Theme and appearence related label Jun 13, 2024
@merisbahti
Copy link
Contributor Author

Sorry, can you review again? The color in the theme was actually wrong

@pascalkuthe pascalkuthe merged commit afe9049 into helix-editor:master Jun 18, 2024
6 checks passed
@merisbahti merisbahti deleted the jump-colors-github-dark branch June 18, 2024 08:40
smortime pushed a commit to smortime/helix that referenced this pull request Jul 10, 2024
mxxntype pushed a commit to mxxntype/helix that referenced this pull request Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-theme Area: Theme and appearence related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants