Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DAP: Deserialize number IDs #10943

Merged
merged 5 commits into from
Jun 15, 2024

Conversation

slawomirlech
Copy link
Contributor

This issue should address issue with parsing messages from debugpy #6265. Please note that this doesn't fix issue with helix messing up terminal as now it is happening upon hitting breakpoint.

helix-dap/Cargo.toml Outdated Show resolved Hide resolved
@the-mikedavis the-mikedavis added the A-debug-adapter Area: Debug adapter client label Jun 13, 2024
@slawomirlech slawomirlech marked this pull request as draft June 13, 2024 14:26
@slawomirlech slawomirlech marked this pull request as ready for review June 13, 2024 14:52
@the-mikedavis the-mikedavis changed the title Fix deserialization of id DAP: Deserialize number IDs Jun 13, 2024
@archseer archseer merged commit dbacaad into helix-editor:master Jun 15, 2024
6 checks passed
AOx0 pushed a commit to AOx0/helix that referenced this pull request Jun 15, 2024
* Fix deserialization of id

* Removing external dependencies

This reverts commit 27962af.

* Fix incorrect import

* Adding tests

* Moved tests

---------

Co-authored-by: Sławomir Lech <[email protected]>
smortime pushed a commit to smortime/helix that referenced this pull request Jul 10, 2024
* Fix deserialization of id

* Removing external dependencies

This reverts commit 27962af.

* Fix incorrect import

* Adding tests

* Moved tests

---------

Co-authored-by: Sławomir Lech <[email protected]>
mxxntype pushed a commit to mxxntype/helix that referenced this pull request Aug 14, 2024
* Fix deserialization of id

* Removing external dependencies

This reverts commit 27962af.

* Fix incorrect import

* Adding tests

* Moved tests

---------

Co-authored-by: Sławomir Lech <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-debug-adapter Area: Debug adapter client
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants