fix(editor): prevent overflow in count modifier #10930
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RoloEdits
changed the title
RoloEdits
force-pushed
the
editor-count-overflow
branch
from
432cbe3
to
69a6d6a
Compare
the-mikedavis
approved these changes
Jun 12, 2024
pascalkuthe
approved these changes
Jun 13, 2024
AOx0
pushed a commit
to AOx0/helix
that referenced
this pull request
Jun 15, 2024
smortime
pushed a commit
to smortime/helix
that referenced
this pull request
Jul 10, 2024
mxxntype
pushed a commit
to mxxntype/helix
that referenced
this pull request
Aug 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current behavior allowed a user to input a more than reasonable value for count, where it could grow till the full value was larger than the allotted render width, and could eventually overflow.
This pull request takes guidance from this comment by @the-mikedavis and caps the value to be below 100,000,000. This would leave the full value viewable and prevent any overflow.
There were other options, such as converting to a string first to check the length, and then dropping the digit that would grow past the allotted render width, keeping a rolling in-render value, but this would add an allocation each time even when not going beyond the selected size.
Ultimately, it was decided that this would be a low percentage issue, and thus not worth an allocation or complexity something like that would add.
To note, the render width is 15 characters wide. 100,000,000 was chosen from guidance, but 999,999,999,999,999 would be the highest value within the 15 character size constraint.
Current:
PR:
Fixes: #10922