Improve readability of virtual text with 'noctis' theme #10910
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
\cc @0rphee what do you think? |
|
It seems fine, thanks @emilyyyylime! |
pascalkuthe
approved these changes
Jun 11, 2024
the-mikedavis
approved these changes
Jun 11, 2024
mxxntype
pushed a commit
to mxxntype/helix
that referenced
this pull request
Jun 12, 2024
AOx0
pushed a commit
to AOx0/helix
that referenced
this pull request
Jun 15, 2024
smortime
pushed a commit
to smortime/helix
that referenced
this pull request
Jul 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This affects both
goto_wordand LSP inlay hints.Before:
https://webaim.org/resources/contrastchecker/?fcolor=073A40&bcolor=00262A
After:
https://webaim.org/resources/contrastchecker/?fcolor=0D6772&bcolor=00262A
I just chose a similar colour from the pallet defined by noctis; Notably, the new colours still don't pass the accessibility contrast threshold for WCAG 2.0 level AA. This might be something to consider, but perhaps is acceptable as these elements are meant to not stick out.