Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

base16_default: add styles to newer unthemed features #10858

Merged
merged 2 commits into from
Jun 23, 2024

Conversation

jdek
Copy link
Contributor

@jdek jdek commented May 31, 2024

Currently, virtual text such as LSP inlay is impossible to distinguish from 'real' text by default; the color-modes option does nothing. I've added a default gray similar to comments (with italics, if supported to more easily distinguish, but we can probably assume that inlay mostly wont be inside comments). Also added ui.statusline.insert to match diff.plus and ui.statusline.select to match the selection colour, ui.statusline.normal is intentionally left unthemed.

jdek added 2 commits May 31, 2024 02:12
Previously virtual text such as LSP inlay was impossible to distinguish
from 'real' text by default.

Signed-off-by: J. Dekker <[email protected]>
@the-mikedavis the-mikedavis added the A-theme Area: Theme and appearence related label Jun 4, 2024
@archseer archseer merged commit 3b5f2e6 into helix-editor:master Jun 23, 2024
6 checks passed
smortime pushed a commit to smortime/helix that referenced this pull request Jul 10, 2024
…0858)

* base16_default: add `ui.statusline` for `color-modes`

Signed-off-by: J. Dekker <[email protected]>

* base16_default: add `ui.virtual` default

Previously virtual text such as LSP inlay was impossible to distinguish
from 'real' text by default.

Signed-off-by: J. Dekker <[email protected]>

---------

Signed-off-by: J. Dekker <[email protected]>
mxxntype pushed a commit to mxxntype/helix that referenced this pull request Aug 14, 2024
…0858)

* base16_default: add `ui.statusline` for `color-modes`

Signed-off-by: J. Dekker <[email protected]>

* base16_default: add `ui.virtual` default

Previously virtual text such as LSP inlay was impossible to distinguish
from 'real' text by default.

Signed-off-by: J. Dekker <[email protected]>

---------

Signed-off-by: J. Dekker <[email protected]>
kyruzic pushed a commit to kyruzic/helix that referenced this pull request Sep 27, 2024
…0858)

* base16_default: add `ui.statusline` for `color-modes`

Signed-off-by: J. Dekker <[email protected]>

* base16_default: add `ui.virtual` default

Previously virtual text such as LSP inlay was impossible to distinguish
from 'real' text by default.

Signed-off-by: J. Dekker <[email protected]>

---------

Signed-off-by: J. Dekker <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-theme Area: Theme and appearence related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants