Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correctly reset inlay hints when stopping or restarting LSPs for a document #10741

Merged

Conversation

poliorcetics
Copy link
Contributor

Stopping or restarting an LSP currently does not cleanup the inlay hints for the documents.

They're correctly recomputed later in the restart case if the restarted LSP supports them: changing the binary and restarting can change that behaviour (e.g. after an update, which is reason to call :lsp-restart on an open document)

@kirawi kirawi added A-language-server Area: Language server client C-bug Category: This is a bug E-easy Call for participation: Experience needed to fix: Easy / not much labels May 16, 2024
@poliorcetics
Copy link
Contributor Author

The test failure is unrelated to this MR (or I'm very confused)

@the-mikedavis the-mikedavis merged commit 9722656 into helix-editor:master Jun 2, 2024
6 checks passed
@poliorcetics poliorcetics deleted the ab/push-yuopnrvpvntp branch June 2, 2024 21:26
Vulpesx pushed a commit to Vulpesx/helix that referenced this pull request Jun 7, 2024
smortime pushed a commit to smortime/helix that referenced this pull request Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-language-server Area: Language server client C-bug Category: This is a bug E-easy Call for participation: Experience needed to fix: Easy / not much
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants