Added missing colors to dark_high_contrast theme for XML/HTML highlighting #10705
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'd been using this theme quite a while because it looks the nicest to my dyslexia. That said, when I open up XML or HTML documents, they pretty much always show up in complete white, except for attribute values. Finally decided to take a look at why, and added the two colors (`tag` & `attribute`) needed to make the theme actually usable with the two formats.
the-mikedavis
approved these changes
May 7, 2024
the-mikedavis
added
A-theme
pascalkuthe
approved these changes
May 7, 2024
Vulpesx
pushed a commit
to Vulpesx/helix
that referenced
this pull request
Jun 7, 2024
I'd been using this theme quite a while because it looks the nicest to my dyslexia. That said, when I open up XML or HTML documents, they pretty much always show up in complete white, except for attribute values. Finally decided to take a look at why, and added the two colors (`tag` & `attribute`) needed to make the theme actually usable with the two formats.
Chirikumbrah
pushed a commit
to Chirikumbrah/helix
that referenced
this pull request
Jun 15, 2024
I'd been using this theme quite a while because it looks the nicest to my dyslexia. That said, when I open up XML or HTML documents, they pretty much always show up in complete white, except for attribute values. Finally decided to take a look at why, and added the two colors (`tag` & `attribute`) needed to make the theme actually usable with the two formats.
smortime
pushed a commit
to smortime/helix
that referenced
this pull request
Jul 10, 2024
I'd been using this theme quite a while because it looks the nicest to my dyslexia. That said, when I open up XML or HTML documents, they pretty much always show up in complete white, except for attribute values. Finally decided to take a look at why, and added the two colors (`tag` & `attribute`) needed to make the theme actually usable with the two formats.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'd been using this theme quite a while because it looks the nicest to my dyslexia. That said, when I open up XML or HTML documents, they pretty much always show up in complete white, except for attribute values.
Finally decided to take a look at why, and added the two colors (
tag&attribute) needed to make the theme actually usable with the two formats.