Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose all flake outputs through flake-compat #10673

Merged
merged 1 commit into from
May 6, 2024

Conversation

mjm
Copy link
Contributor

@mjm mjm commented May 4, 2024

Currently, the default.nix for Helix only exposes a single package which is always built for builtins.currentSystem, the system where the Nix code is being evaluated. If you aren't using flakes, there's not an easy way to build Helix for a different system.

This change instead does what most other users of flake-compat do in default.nix: expose all of the flake's outputs. This allows consumers to use the package for a specific system if they need to by doing something like (import helix).packages.${system}.helix. And the current behavior is still accessible by doing (import helix).default instead of import helix as you currently can.

@the-mikedavis the-mikedavis added E-easy Call for participation: Experience needed to fix: Easy / not much A-packaging Area: Packaging and bundling S-waiting-on-review Status: Awaiting review from a maintainer. labels May 6, 2024
@archseer archseer merged commit e16a4f8 into helix-editor:master May 6, 2024
6 checks passed
@mjm mjm deleted the default-nix branch May 6, 2024 16:39
Vulpesx pushed a commit to Vulpesx/helix that referenced this pull request Jun 7, 2024
Chirikumbrah pushed a commit to Chirikumbrah/helix that referenced this pull request Jun 15, 2024
smortime pushed a commit to smortime/helix that referenced this pull request Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-packaging Area: Packaging and bundling E-easy Call for participation: Experience needed to fix: Easy / not much S-waiting-on-review Status: Awaiting review from a maintainer.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants