Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add completion/signature bindings to keymap.md #10654

Merged
merged 2 commits into from
May 2, 2024

Conversation

rcorre
Copy link
Contributor

@rcorre rcorre commented May 1, 2024

PR #9974 added alt-p/alt-n keybindings to scroll through signatures. This wasn't very discoverable, as it's not in the docs or the command palette.

This also removes a broken link for "comment mode" in the table of contents.

PR helix-editor#9974 added alt-p/alt-n keybindings to scroll through signatures.
This wasn't very discoverable, as it's not in the docs or the command palette.

This also removes a broken link for "comment mode" in the table of contents.
Comment on lines 16 to 17
- [Completion Popup](#completion-popup)
- [Signature Popup](#signature-popup)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For naming let's call these the "Completion Menu" and "Signature-help Popup"

@@ -12,8 +12,9 @@
- [Match mode](#match-mode)
- [Window mode](#window-mode)
- [Space mode](#space-mode)
- [Comment mode](#comment-mode)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this might be an artifact of #4718, IIRC that originally had a comment mode under space mode. Should be safe to remove 👍

@the-mikedavis the-mikedavis added the A-documentation Area: Documentation improvements label May 1, 2024
@rcorre rcorre requested a review from the-mikedavis May 2, 2024 00:40
@pascalkuthe pascalkuthe merged commit 31273c6 into helix-editor:master May 2, 2024
6 checks passed
@rcorre rcorre deleted the patch-1 branch May 2, 2024 14:09
Vulpesx pushed a commit to Vulpesx/helix that referenced this pull request Jun 7, 2024
* Add completion/signature bindings to keymap.md

PR helix-editor#9974 added alt-p/alt-n keybindings to scroll through signatures.
This wasn't very discoverable, as it's not in the docs or the command palette.

This also removes a broken link for "comment mode" in the table of contents.

* Update keymap.md
Chirikumbrah pushed a commit to Chirikumbrah/helix that referenced this pull request Jun 15, 2024
* Add completion/signature bindings to keymap.md

PR helix-editor#9974 added alt-p/alt-n keybindings to scroll through signatures.
This wasn't very discoverable, as it's not in the docs or the command palette.

This also removes a broken link for "comment mode" in the table of contents.

* Update keymap.md
smortime pushed a commit to smortime/helix that referenced this pull request Jul 10, 2024
* Add completion/signature bindings to keymap.md

PR helix-editor#9974 added alt-p/alt-n keybindings to scroll through signatures.
This wasn't very discoverable, as it's not in the docs or the command palette.

This also removes a broken link for "comment mode" in the table of contents.

* Update keymap.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-documentation Area: Documentation improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants