Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #10610
this was a minor regression from #10539
the main problem was a mix-up where the new client was removed from the registry instead of the old one (accidentally used
cliend.id()
instead ofold_cient.id()
) but I also noticed that we don't actually stop an old lsp if the new one fails to start and similarly don't restart a server if it failed to start/was stopped in the past which doesn't seem correct, so I fixed that too.