Disable crossterm's support for NO_COLOR. #10514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
we should just set this by default. NO_COLOR does not make sense for helix since you can't even see the selection. I don't want to add a config for this |
Since helix isn't usable without color support, honoring this does nobody any good.
kevin-vigor
changed the title
|
@pascalkuthe : makes sense to me :) |
postsolar
pushed a commit
to postsolar/helix
that referenced
this pull request
Apr 20, 2024
Since helix isn't usable without color support, honoring this does nobody any good.
Vulpesx
pushed a commit
to Vulpesx/helix
that referenced
this pull request
Jun 7, 2024
Since helix isn't usable without color support, honoring this does nobody any good.
Chirikumbrah
pushed a commit
to Chirikumbrah/helix
that referenced
this pull request
Jun 15, 2024
Since helix isn't usable without color support, honoring this does nobody any good.
smortime
pushed a commit
to smortime/helix
that referenced
this pull request
Jul 10, 2024
Since helix isn't usable without color support, honoring this does nobody any good.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This option allows overriding the NO_COLOR environment variable, which crossterm honors by default.
As noted in https://no-color.org/, "User-level configuration files and per-instance command-line arguments should override $NO_COLOR".