Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable crossterm's support for NO_COLOR. #10514

Merged
merged 1 commit into from
Apr 20, 2024

Conversation

kevin-vigor
Copy link
Contributor

This option allows overriding the NO_COLOR environment variable, which crossterm honors by default.

As noted in https://no-color.org/, "User-level configuration files and per-instance command-line arguments should override $NO_COLOR".

@pascalkuthe
Copy link
Member

we should just set this by default. NO_COLOR does not make sense for helix since you can't even see the selection. I don't want to add a config for this

Since helix isn't usable without color support, honoring this does
nobody any good.
@kevin-vigor kevin-vigor changed the title Add a "yes-color" configuration option to override NO_COLOR Disable crossterm's support for NO_COLOR. Apr 20, 2024
@kevin-vigor
Copy link
Contributor Author

@pascalkuthe : makes sense to me :)

@archseer archseer merged commit 18d5cac into helix-editor:master Apr 20, 2024
6 checks passed
postsolar pushed a commit to postsolar/helix that referenced this pull request Apr 20, 2024
Since helix isn't usable without color support, honoring this does
nobody any good.
Vulpesx pushed a commit to Vulpesx/helix that referenced this pull request Jun 7, 2024
Since helix isn't usable without color support, honoring this does
nobody any good.
Chirikumbrah pushed a commit to Chirikumbrah/helix that referenced this pull request Jun 15, 2024
Since helix isn't usable without color support, honoring this does
nobody any good.
smortime pushed a commit to smortime/helix that referenced this pull request Jul 10, 2024
Since helix isn't usable without color support, honoring this does
nobody any good.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants