Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enabled traversing multiple buffers at once #10463

Merged
merged 5 commits into from
Apr 16, 2024

Conversation

mjbozo
Copy link
Contributor

@mjbozo mjbozo commented Apr 16, 2024

This aims to address #10400 and allows prefixing gn and gp commands with a number to cycle through multiple buffers.

Feedback is always welcome.

This is my first attempt at contributing to something, so go easy on me 😅

archseer
archseer previously approved these changes Apr 16, 2024
Copy link
Member

@archseer archseer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much cleaner!

@the-mikedavis the-mikedavis linked an issue Apr 16, 2024 that may be closed by this pull request
@kirawi kirawi added A-helix-term Area: Helix term improvements S-waiting-on-review Status: Awaiting review from a maintainer. labels Apr 16, 2024
@kirawi
Copy link
Member

kirawi commented Apr 16, 2024

You have to run cargo fmt to get CI to pass.

@mjbozo
Copy link
Contributor Author

mjbozo commented Apr 16, 2024

You have to run cargo fmt to get CI to pass.

My bad! cargo fmt now executed

Copy link
Member

@pascalkuthe pascalkuthe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah much nicer, one nit to make it even more concise is to use nth instead of skip(n).next()

helix-term/src/commands.rs Outdated Show resolved Hide resolved
helix-term/src/commands.rs Outdated Show resolved Hide resolved
@pascalkuthe pascalkuthe merged commit 8e16172 into helix-editor:master Apr 16, 2024
6 checks passed
shaleh pushed a commit to shaleh/helix that referenced this pull request Apr 16, 2024
* Enable traversing multiple buffers at once

* run cargo fmt

* simplify iterator call
postsolar pushed a commit to postsolar/helix that referenced this pull request Apr 20, 2024
* Enable traversing multiple buffers at once

* run cargo fmt

* simplify iterator call
Vulpesx pushed a commit to Vulpesx/helix that referenced this pull request Jun 7, 2024
* Enable traversing multiple buffers at once

* run cargo fmt

* simplify iterator call
Chirikumbrah pushed a commit to Chirikumbrah/helix that referenced this pull request Jun 15, 2024
* Enable traversing multiple buffers at once

* run cargo fmt

* simplify iterator call
smortime pushed a commit to smortime/helix that referenced this pull request Jul 10, 2024
* Enable traversing multiple buffers at once

* run cargo fmt

* simplify iterator call
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-helix-term Area: Helix term improvements S-waiting-on-review Status: Awaiting review from a maintainer.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"<number> goto [next/previous] buffer" only executes once
5 participants