Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement read command #10447

Merged
merged 8 commits into from
Apr 17, 2024
Merged

Implement read command #10447

merged 8 commits into from
Apr 17, 2024

Commits on Apr 16, 2024

  1. Implement read command. 

    Resurrects helix-editor#3966. This is 100% @idursun's work. Using read_to_string from helix-editor#7431.
Co-authored-by: [email protected]
    @shaleh
    shaleh committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    f0f25b6 View commit details
    Browse the repository at this point in the history

  2. Update test.

    @shaleh
    shaleh committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    3045fc1 View commit details
    Browse the repository at this point in the history

  3. Apply suggestions from code review 

    Co-authored-by: Michael Davis <[email protected]>
    @shaleh @the-mikedavis
    shaleh and the-mikedavis committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    9244cab View commit details
    Browse the repository at this point in the history

  4. Use read here too.

    @shaleh
    shaleh committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    d8c8cb2 View commit details
    Browse the repository at this point in the history

  5. Resolve current round of code review. 

    Co-authored-by: Ibrahim Dursun <[email protected]>
    @shaleh @idursun
    shaleh and idursun committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    a8c2d48 View commit details
    Browse the repository at this point in the history

Commits on Apr 17, 2024

  1. Merge remote-tracking branch 'upstream/master' into implement-read-co… 

    …mmand
    @shaleh
    shaleh committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    1de05d3 View commit details
    Browse the repository at this point in the history

  2. Use LineFeedHandling to be cross platform.

    @shaleh
    shaleh committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    cff8801 View commit details
    Browse the repository at this point in the history

  3. Apply suggestions from code review 

    Co-authored-by: Michael Davis <[email protected]>
    @shaleh @the-mikedavis
    shaleh and the-mikedavis committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    9368af5 View commit details
    Browse the repository at this point in the history