Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add bufferline and cursorline colors to vim dark theme #10444

Merged
merged 1 commit into from
Apr 15, 2024
Merged

Add bufferline and cursorline colors to vim dark theme #10444

merged 1 commit into from
Apr 15, 2024

Conversation

SufianBabri
Copy link
Contributor

@SufianBabri SufianBabri commented Apr 14, 2024 •
edited
Loading

In the "vim dark high contrast" theme, I have set the bufferline and cursorline colors, so it does the following:

  1. the currently active buffer is easily recognizable (just like in the other themes)
  2. the current line has a slightly lighter color than the bg

Without fix:
Without fix

With fix:
With fix

@kirawi kirawi added the A-theme Area: Theme and appearence related label Apr 14, 2024
@SufianBabri SufianBabri changed the title Fix bufferline colors of vim dark theme Add bufferline and cursorline colors to vim dark theme Apr 15, 2024
@the-mikedavis the-mikedavis merged commit 1245760 into helix-editor:master Apr 15, 2024
6 checks passed
@SufianBabri SufianBabri deleted the vim-theme-fix branch April 16, 2024 00:43
shaleh pushed a commit to shaleh/helix that referenced this pull request Apr 16, 2024
@SufianBabri @shaleh
Add bufferline and cursorline colors to vim dark theme (helix-editor#…
d84ef13 
…10444)
postsolar pushed a commit to postsolar/helix that referenced this pull request Apr 20, 2024
@SufianBabri @postsolar
Add bufferline and cursorline colors to vim dark theme (helix-editor#…
e2a4e67 
…10444)
Vulpesx pushed a commit to Vulpesx/helix that referenced this pull request Jun 7, 2024
@SufianBabri @Vulpesx
Add bufferline and cursorline colors to vim dark theme (helix-editor#…
6594e65 
…10444)
Chirikumbrah pushed a commit to Chirikumbrah/helix that referenced this pull request Jun 15, 2024
@SufianBabri @Chirikumbrah
Add bufferline and cursorline colors to vim dark theme (helix-editor#…
b4bb80a 
…10444)
smortime pushed a commit to smortime/helix that referenced this pull request Jul 10, 2024
@SufianBabri
Add bufferline and cursorline colors to vim dark theme (helix-editor#…
0ab4d28 
…10444)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pascalkuthe pascalkuthe pascalkuthe approved these changes

@the-mikedavis the-mikedavis the-mikedavis approved these changes

Assignees
No one assigned
Labels
A-theme Area: Theme and appearence related
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@SufianBabri @the-mikedavis @pascalkuthe @kirawi