Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix char/byte index mixup in overlay rendering #10317

Merged
merged 1 commit into from
Apr 9, 2024

Conversation

pascalkuthe
Copy link
Member

@pascalkuthe pascalkuthe commented Apr 9, 2024

closes #10315

this code was copy pased from elsewhere but overlay highlights use char indecies not byte indecies. One day we will use byte indecies everywhere and avoid these mixups

@pascalkuthe pascalkuthe added C-bug Category: This is a bug E-easy Call for participation: Experience needed to fix: Easy / not much A-helix-term Area: Helix term improvements S-waiting-on-review Status: Awaiting review from a maintainer. labels Apr 9, 2024
@Iorvethe
Copy link
Contributor

Iorvethe commented Apr 9, 2024

Just tried your branch, and it fixes the issue. Thanks for the quick fix!

@archseer archseer merged commit f601b7c into master Apr 9, 2024
6 checks passed
@archseer archseer deleted the fix_overlay_highlights branch April 9, 2024 16:49
postsolar pushed a commit to postsolar/helix that referenced this pull request Apr 20, 2024
mtoohey31 pushed a commit to mtoohey31/helix that referenced this pull request Jun 2, 2024
Vulpesx pushed a commit to Vulpesx/helix that referenced this pull request Jun 7, 2024
smortime pushed a commit to smortime/helix that referenced this pull request Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-helix-term Area: Helix term improvements C-bug Category: This is a bug E-easy Call for participation: Experience needed to fix: Easy / not much S-waiting-on-review Status: Awaiting review from a maintainer.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

incorrect jump label highlight when non-ascii chars are used
4 participants