Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve popup position #10257

Merged
merged 2 commits into from
Apr 20, 2024
Merged

Improve popup position #10257

merged 2 commits into from
Apr 20, 2024

Commits on Apr 19, 2024

  1. Improve popup position 

    Make the popup positions more consistent.
Improvements:
1. if the signature popup content is bigger than the available space,
   then the popup is always shown under the cursor, even if there more
   space above the cursor than below
2. There is no mutation anymore inside required_size. Maybe in the future
   we can update all widgets to have no mutations and change the trait

Signed-off-by: Ben Fekih, Hichem <[email protected]>
    @karthago1
    karthago1 committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    6574617 View commit details
    Browse the repository at this point in the history

  2. popup: call required_size only once while rendering 

    to speed up the rendering a little

Signed-off-by: Ben Fekih, Hichem <[email protected]>
    @karthago1
    karthago1 committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    5deff63 View commit details
    Browse the repository at this point in the history