Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correctly open URLs surrounded by <> #10180

Closed

Conversation

poliorcetics
Copy link
Contributor

rustoc can warn about "naked" links that are not surrounded by <>. When fixing the link, helix becomes unable to open the URL, instead opening a file named <URL>.

Since I couldn't think of a single case where a file starting or ending with <> would happen since shells use those as control characters and tend to discourage that pattern, I simply added to the trim list.

@the-mikedavis
Copy link
Member

Also see #10157

We want to do away with the surrounding character checking and switch to something similar to what neovim does in this case: #9065

@the-mikedavis
Copy link
Member

I'll close this out as I've just merged down #9065 which handles this case. The old code had problems like not handling periods well, for example: Hello: <https://github.com/helix-editor/helix>.

@poliorcetics poliorcetics deleted the ab/push-luxmzyoqspxn branch April 6, 2024 21:54
@poliorcetics
Copy link
Contributor Author

#9065

Oh nice 🤩 I wasn't subscribed to that one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants