Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

show newest options in jumplist picker first, fix docs #10095

Merged
merged 2 commits into from
Apr 2, 2024

Conversation

woojiq
Copy link
Contributor

@woojiq woojiq commented Apr 1, 2024

These are a few patches I've collected while using Helix. Let the world finally see them.

commit 94db151 : docs: mention <space>g changed file picker. This was missed in the #5645

These two are personal preferences, but I think they're fair:
commit a4b5b4c : picker(jumplist): show newest options on top instead of bottom
commit ef13bf5 : picker(global-search): append line number to found options

You can reject them all, select only docs commit, or do whatever you want :)

@woojiq woojiq changed the title Patch series: fix docs, improve pickers (global-search, jumplist). fix docs, improve global-search and jumplist picker Apr 1, 2024
@pascalkuthe
Copy link
Member

commit ef13bf5 : picker(global-search): append line number to found options

the rest lgtm but I don't think this should be added here. If we are going to do this it should be a separate column as part of #9647 but I am even critical of that. What is your usecase here. I don't think people generally search by line (if you already know the line why bother searching).

We could show gutters with line number instead (may be nice for diff gutter aswell) but that also takes up more vertical space

@woojiq
Copy link
Contributor Author

woojiq commented Apr 2, 2024

What is your usecase here.

It's hard to explain, you have to feel it. Helped me on a large codebase without Lsp. But as I said, these are just my preferences, I can live without it on master.

We could show gutters with line number instead (may be nice for diff gutter aswell) but that also takes up more vertical space

This will work for me too. For now, I can remove it and maybe create an issue to request config option: "line numbers in pickers" so that all possible pickers are consistent (jumplist, buffer, symbol, etc). Then you will decide whether this feature has the right to live.

@woojiq woojiq changed the title fix docs, improve global-search and jumplist picker show newest options in jumplist picker first, fix docs Apr 2, 2024
pascalkuthe
pascalkuthe previously approved these changes Apr 2, 2024
@pascalkuthe pascalkuthe merged commit cc8290f into helix-editor:master Apr 2, 2024
6 checks passed
@woojiq woojiq deleted the misc branch April 2, 2024 14:47
Desdaemon pushed a commit to Desdaemon/helix that referenced this pull request Apr 3, 2024
…10095)

* docs: mention `<space>g` changed file picker

* picker(jumplist): show jumps in order from latest to oldest
postsolar pushed a commit to postsolar/helix that referenced this pull request Apr 4, 2024
…10095)

* docs: mention `<space>g` changed file picker

* picker(jumplist): show jumps in order from latest to oldest
postsolar pushed a commit to postsolar/helix that referenced this pull request Apr 4, 2024
…10095)

* docs: mention `<space>g` changed file picker

* picker(jumplist): show jumps in order from latest to oldest
postsolar pushed a commit to postsolar/helix that referenced this pull request Apr 4, 2024
…10095)

* docs: mention `<space>g` changed file picker

* picker(jumplist): show jumps in order from latest to oldest
postsolar pushed a commit to postsolar/helix that referenced this pull request Apr 4, 2024
…10095)

* docs: mention `<space>g` changed file picker

* picker(jumplist): show jumps in order from latest to oldest
postsolar pushed a commit to postsolar/helix that referenced this pull request Apr 20, 2024
…10095)

* docs: mention `<space>g` changed file picker

* picker(jumplist): show jumps in order from latest to oldest
mtoohey31 pushed a commit to mtoohey31/helix that referenced this pull request Jun 2, 2024
…10095)

* docs: mention `<space>g` changed file picker

* picker(jumplist): show jumps in order from latest to oldest
Vulpesx pushed a commit to Vulpesx/helix that referenced this pull request Jun 7, 2024
…10095)

* docs: mention `<space>g` changed file picker

* picker(jumplist): show jumps in order from latest to oldest
smortime pushed a commit to smortime/helix that referenced this pull request Jul 10, 2024
…10095)

* docs: mention `<space>g` changed file picker

* picker(jumplist): show jumps in order from latest to oldest
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants