Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Buildkite command/commands support to yaml injections #10090

Merged
merged 2 commits into from
Apr 2, 2024

Conversation

mmlb
Copy link
Contributor

@mmlb mmlb commented Apr 1, 2024

Adds injection support to yaml for buildkite command steps.

mmlb added 2 commits April 1, 2024 13:15
Go back to original intent when this code was first written now that the
tree-sitter version used supports any-of?.
Buildkite uses `command` (`commands` is an alias) to define the
command(s) to run for the step.
@the-mikedavis the-mikedavis added S-waiting-on-review Status: Awaiting review from a maintainer. A-language-support Area: Support for programming/text languages labels Apr 1, 2024
@mmlb
Copy link
Contributor Author

mmlb commented Apr 1, 2024

Looks like the injection works with circleci too: https://circleci.com/docs/configuration-reference/#run

@pascalkuthe pascalkuthe merged commit 4b236f3 into helix-editor:master Apr 2, 2024
6 checks passed
@mmlb mmlb deleted the add-buildkite-yaml-injections branch April 2, 2024 00:52
Desdaemon pushed a commit to Desdaemon/helix that referenced this pull request Apr 3, 2024
…or#10090)

* Use any-of instead of match in yaml injections

Go back to original intent when this code was first written now that the
tree-sitter version used supports any-of?.

* yaml/injections: Add injection for Buildkite

Buildkite uses `command` (`commands` is an alias) to define the
command(s) to run for the step.
postsolar pushed a commit to postsolar/helix that referenced this pull request Apr 4, 2024
…or#10090)

* Use any-of instead of match in yaml injections

Go back to original intent when this code was first written now that the
tree-sitter version used supports any-of?.

* yaml/injections: Add injection for Buildkite

Buildkite uses `command` (`commands` is an alias) to define the
command(s) to run for the step.
postsolar pushed a commit to postsolar/helix that referenced this pull request Apr 4, 2024
…or#10090)

* Use any-of instead of match in yaml injections

Go back to original intent when this code was first written now that the
tree-sitter version used supports any-of?.

* yaml/injections: Add injection for Buildkite

Buildkite uses `command` (`commands` is an alias) to define the
command(s) to run for the step.
postsolar pushed a commit to postsolar/helix that referenced this pull request Apr 4, 2024
…or#10090)

* Use any-of instead of match in yaml injections

Go back to original intent when this code was first written now that the
tree-sitter version used supports any-of?.

* yaml/injections: Add injection for Buildkite

Buildkite uses `command` (`commands` is an alias) to define the
command(s) to run for the step.
postsolar pushed a commit to postsolar/helix that referenced this pull request Apr 4, 2024
…or#10090)

* Use any-of instead of match in yaml injections

Go back to original intent when this code was first written now that the
tree-sitter version used supports any-of?.

* yaml/injections: Add injection for Buildkite

Buildkite uses `command` (`commands` is an alias) to define the
command(s) to run for the step.
postsolar pushed a commit to postsolar/helix that referenced this pull request Apr 20, 2024
…or#10090)

* Use any-of instead of match in yaml injections

Go back to original intent when this code was first written now that the
tree-sitter version used supports any-of?.

* yaml/injections: Add injection for Buildkite

Buildkite uses `command` (`commands` is an alias) to define the
command(s) to run for the step.
mtoohey31 pushed a commit to mtoohey31/helix that referenced this pull request Jun 2, 2024
…or#10090)

* Use any-of instead of match in yaml injections

Go back to original intent when this code was first written now that the
tree-sitter version used supports any-of?.

* yaml/injections: Add injection for Buildkite

Buildkite uses `command` (`commands` is an alias) to define the
command(s) to run for the step.
Vulpesx pushed a commit to Vulpesx/helix that referenced this pull request Jun 7, 2024
…or#10090)

* Use any-of instead of match in yaml injections

Go back to original intent when this code was first written now that the
tree-sitter version used supports any-of?.

* yaml/injections: Add injection for Buildkite

Buildkite uses `command` (`commands` is an alias) to define the
command(s) to run for the step.
smortime pushed a commit to smortime/helix that referenced this pull request Jul 10, 2024
…or#10090)

* Use any-of instead of match in yaml injections

Go back to original intent when this code was first written now that the
tree-sitter version used supports any-of?.

* yaml/injections: Add injection for Buildkite

Buildkite uses `command` (`commands` is an alias) to define the
command(s) to run for the step.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-language-support Area: Support for programming/text languages S-waiting-on-review Status: Awaiting review from a maintainer.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants