Add jump-label styling for base16 themes #10076
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The other base16 themes should be updated alongside for consistency |
|
All done @archseer |
pawelgrzybek
changed the title
the-mikedavis
previously approved these changes
Apr 1, 2024
the-mikedavis
added
A-theme
|
I think just underlining is pretty hard to read. I have seen that feedback multiple times that without a color change the jumpmode labels are pretty hard to notice. I think it also makes sense since the jumplabels are not part of the normal text so it makes no sense to syntax highlight them as normal. I would atleast change the foreground color but ideally also male them bold like other themes so it's easier to notice. |
|
@pascalkuthe Fair point. Hopefully that feels better.
|
pascalkuthe
approved these changes
Apr 1, 2024
the-mikedavis
approved these changes
Apr 1, 2024
Desdaemon
pushed a commit
to Desdaemon/helix
that referenced
this pull request
Apr 3, 2024
* add jump-label styling for base16_transparent theme * keep the change consistent with other themes from base16 family * update jump-labels color to blue and make them bold
postsolar
pushed a commit
to postsolar/helix
that referenced
this pull request
Apr 4, 2024
* add jump-label styling for base16_transparent theme * keep the change consistent with other themes from base16 family * update jump-labels color to blue and make them bold
postsolar
pushed a commit
to postsolar/helix
that referenced
this pull request
Apr 4, 2024
* add jump-label styling for base16_transparent theme * keep the change consistent with other themes from base16 family * update jump-labels color to blue and make them bold
postsolar
pushed a commit
to postsolar/helix
that referenced
this pull request
Apr 4, 2024
* add jump-label styling for base16_transparent theme * keep the change consistent with other themes from base16 family * update jump-labels color to blue and make them bold
postsolar
pushed a commit
to postsolar/helix
that referenced
this pull request
Apr 4, 2024
* add jump-label styling for base16_transparent theme * keep the change consistent with other themes from base16 family * update jump-labels color to blue and make them bold
postsolar
pushed a commit
to postsolar/helix
that referenced
this pull request
Apr 20, 2024
* add jump-label styling for base16_transparent theme * keep the change consistent with other themes from base16 family * update jump-labels color to blue and make them bold
mtoohey31
pushed a commit
to mtoohey31/helix
that referenced
this pull request
Jun 2, 2024
* add jump-label styling for base16_transparent theme * keep the change consistent with other themes from base16 family * update jump-labels color to blue and make them bold
Vulpesx
pushed a commit
to Vulpesx/helix
that referenced
this pull request
Jun 7, 2024
* add jump-label styling for base16_transparent theme * keep the change consistent with other themes from base16 family * update jump-labels color to blue and make them bold
smortime
pushed a commit
to smortime/helix
that referenced
this pull request
Jul 10, 2024
* add jump-label styling for base16_transparent theme * keep the change consistent with other themes from base16 family * update jump-labels color to blue and make them bold
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To respect the minimalistic look of the theme and inherit the link styling from the Web platform, I kept it simple by making labels underlined.