chore: add "ui.virtual.jump-label" to solarized colorschemes #10056
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Most other themes make the jump label bold. I would dfinitly recommend that |
I just tried and I find it far, far worse
It might look "prettier" on a screenshot, but for a quick action like that, I want the keys to be immediately recognizable and for that they need to stand out. Having said that, I just enabled it, and personally I can just keep my customizations, so I'm happy to change to bold in the PR. Just giving my feedback and fixing it while at it. |
|
I think that @pascalkuthe was suggesting making it red and bold rather than one or the other |
|
Oh. I see. I like that even better indeed. |
dpc
force-pushed
the
24-03-30-solarized-jump-label-color
branch
from
3a39439
to
4911923
Compare
the-mikedavis
approved these changes
Mar 30, 2024
pascalkuthe
approved these changes
Mar 30, 2024
Desdaemon
pushed a commit
to Desdaemon/helix
that referenced
this pull request
Apr 3, 2024
postsolar
pushed a commit
to postsolar/helix
that referenced
this pull request
Apr 4, 2024
postsolar
pushed a commit
to postsolar/helix
that referenced
this pull request
Apr 4, 2024
postsolar
pushed a commit
to postsolar/helix
that referenced
this pull request
Apr 4, 2024
postsolar
pushed a commit
to postsolar/helix
that referenced
this pull request
Apr 20, 2024
mtoohey31
pushed a commit
to mtoohey31/helix
that referenced
this pull request
Jun 2, 2024
Vulpesx
pushed a commit
to Vulpesx/helix
that referenced
this pull request
Jun 7, 2024
smortime
pushed a commit
to smortime/helix
that referenced
this pull request
Jul 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't know if there are any recommendations, but red works for me - stands out, and I'm an exclusive solarized-dark user.