Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Helix.appdata.xml spec-compliant #10051

Merged
merged 1 commit into from
Mar 30, 2024
Merged

Make Helix.appdata.xml spec-compliant #10051

merged 1 commit into from
Mar 30, 2024

Conversation

blt-r
Copy link
Contributor

@blt-r blt-r commented Mar 30, 2024

The <description> tag shouldn't be translated, but instead the individual paragraphs. This is kind of weird imo, but a spec is a spec i guess.

The <developer> tag is required. I just put "The Helix Community" in there, but maybe just put @archseer by name?

It turns out, the <requires> tag actually means that the app can't even be installed without that control. What this should be is <recommends>.

@blt-r
Make Helix.appdata.xml spec-compliant
a104874 
- The <description> tag shouldn't be translated, but instead the
  individual paragraphs.
- The <developer> tag is required.
- The <requires> tag actually means that the app can't even be installed
  without that control. What this should be is <recommends>.
the-mikedavis
the-mikedavis approved these changes Mar 30, 2024
View reviewed changes
Copy link
Member

@the-mikedavis the-mikedavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@the-mikedavis the-mikedavis added A-packaging Area: Packaging and bundling S-waiting-on-review Status: Awaiting review from a maintainer. labels Mar 30, 2024
@pascalkuthe pascalkuthe merged commit 3d6f34c into helix-editor:master Mar 30, 2024
6 checks passed
Desdaemon pushed a commit to Desdaemon/helix that referenced this pull request Apr 3, 2024
@blt-r @Desdaemon
Make Helix.appdata.xml spec-compliant (helix-editor#10051)
105b304 
- The <description> tag shouldn't be translated, but instead the
  individual paragraphs.
- The <developer> tag is required.
- The <requires> tag actually means that the app can't even be installed
  without that control. What this should be is <recommends>.
postsolar pushed a commit to postsolar/helix that referenced this pull request Apr 4, 2024
@blt-r @postsolar
Make Helix.appdata.xml spec-compliant (helix-editor#10051)
99c763e 
- The <description> tag shouldn't be translated, but instead the
  individual paragraphs.
- The <developer> tag is required.
- The <requires> tag actually means that the app can't even be installed
  without that control. What this should be is <recommends>.
postsolar pushed a commit to postsolar/helix that referenced this pull request Apr 4, 2024
@blt-r @postsolar
Make Helix.appdata.xml spec-compliant (helix-editor#10051)
3708a4f 
- The <description> tag shouldn't be translated, but instead the
  individual paragraphs.
- The <developer> tag is required.
- The <requires> tag actually means that the app can't even be installed
  without that control. What this should be is <recommends>.
postsolar pushed a commit to postsolar/helix that referenced this pull request Apr 4, 2024
@blt-r @postsolar
Make Helix.appdata.xml spec-compliant (helix-editor#10051)
4ba787f 
- The <description> tag shouldn't be translated, but instead the
  individual paragraphs.
- The <developer> tag is required.
- The <requires> tag actually means that the app can't even be installed
  without that control. What this should be is <recommends>.
postsolar pushed a commit to postsolar/helix that referenced this pull request Apr 20, 2024
@blt-r @postsolar
Make Helix.appdata.xml spec-compliant (helix-editor#10051)
3d8184d 
- The <description> tag shouldn't be translated, but instead the
  individual paragraphs.
- The <developer> tag is required.
- The <requires> tag actually means that the app can't even be installed
  without that control. What this should be is <recommends>.
mtoohey31 pushed a commit to mtoohey31/helix that referenced this pull request Jun 2, 2024
@blt-r @mtoohey31
Make Helix.appdata.xml spec-compliant (helix-editor#10051)
c3deebe 
- The <description> tag shouldn't be translated, but instead the
  individual paragraphs.
- The <developer> tag is required.
- The <requires> tag actually means that the app can't even be installed
  without that control. What this should be is <recommends>.
Vulpesx pushed a commit to Vulpesx/helix that referenced this pull request Jun 7, 2024
@blt-r @Vulpesx
Make Helix.appdata.xml spec-compliant (helix-editor#10051)
05b073e 
- The <description> tag shouldn't be translated, but instead the
  individual paragraphs.
- The <developer> tag is required.
- The <requires> tag actually means that the app can't even be installed
  without that control. What this should be is <recommends>.
smortime pushed a commit to smortime/helix that referenced this pull request Jul 10, 2024
@blt-r
Make Helix.appdata.xml spec-compliant (helix-editor#10051)
d20ff5d 
- The <description> tag shouldn't be translated, but instead the
  individual paragraphs.
- The <developer> tag is required.
- The <requires> tag actually means that the app can't even be installed
  without that control. What this should be is <recommends>.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@the-mikedavis the-mikedavis the-mikedavis approved these changes

@pascalkuthe pascalkuthe pascalkuthe approved these changes

Assignees
No one assigned
Labels
A-packaging Area: Packaging and bundling S-waiting-on-review Status: Awaiting review from a maintainer.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@blt-r @the-mikedavis @pascalkuthe