Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add jump-label to Kanagawa theme + format #10030

Merged
merged 3 commits into from
Mar 28, 2024

Conversation

mlemesle
Copy link
Contributor

I added the ui.virtual.jump-label to the Kanagawa theme and made some formatting.
Please let me know if I overstepped while formatting the file.

I got the colors from the official Kanagawa repository

"ui.virtual.inlay-hint.parameter" = { fg = "carpYellow", modifiers = ["dim"] }
"ui.virtual.inlay-hint.type" = { fg = "waveAqua2", modifiers = ["dim"] }
"ui.virtual.inlay-hint.type" = { fg = "waveAqua2", modifiers = ["dim"] }
"ui.virtual.jump-label" = { fg = "peachRed", bg = "sumiInk0", modifiers = ["bold"] }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wouldn't set a background color. Setting background colors for text can mess with some ui components like cursorline. I don't believe other themes set the background color for jump labels

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your suggestion @pascalkuthe. I wasn't sure about the background either.
The official theme does use one, but it also change the background of the whole background...
I agree, changing the background of the jump-label without changing the whole background is irrelevant.

I pushed a new commit to remove it

Copy link
Member

@the-mikedavis the-mikedavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The reformatting seems unnecessary to me. I don't think it's any easier to read with the =s aligned

@mlemesle
Copy link
Contributor Author

@the-mikedavis Just removed the values alignment from the file !

@the-mikedavis the-mikedavis added A-theme Area: Theme and appearence related S-waiting-on-review Status: Awaiting review from a maintainer. labels Mar 28, 2024
@the-mikedavis the-mikedavis merged commit c69ad7b into helix-editor:master Mar 28, 2024
6 checks passed
Desdaemon pushed a commit to Desdaemon/helix that referenced this pull request Apr 3, 2024
* Add jump-label to Kanagawa theme + format

* Remove bg color for jump-label

* Remove values alignment
postsolar pushed a commit to postsolar/helix that referenced this pull request Apr 4, 2024
* Add jump-label to Kanagawa theme + format

* Remove bg color for jump-label

* Remove values alignment
postsolar pushed a commit to postsolar/helix that referenced this pull request Apr 4, 2024
* Add jump-label to Kanagawa theme + format

* Remove bg color for jump-label

* Remove values alignment
postsolar pushed a commit to postsolar/helix that referenced this pull request Apr 4, 2024
* Add jump-label to Kanagawa theme + format

* Remove bg color for jump-label

* Remove values alignment
postsolar pushed a commit to postsolar/helix that referenced this pull request Apr 20, 2024
* Add jump-label to Kanagawa theme + format

* Remove bg color for jump-label

* Remove values alignment
mtoohey31 pushed a commit to mtoohey31/helix that referenced this pull request Jun 2, 2024
* Add jump-label to Kanagawa theme + format

* Remove bg color for jump-label

* Remove values alignment
Vulpesx pushed a commit to Vulpesx/helix that referenced this pull request Jun 7, 2024
* Add jump-label to Kanagawa theme + format

* Remove bg color for jump-label

* Remove values alignment
smortime pushed a commit to smortime/helix that referenced this pull request Jul 10, 2024
* Add jump-label to Kanagawa theme + format

* Remove bg color for jump-label

* Remove values alignment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-theme Area: Theme and appearence related S-waiting-on-review Status: Awaiting review from a maintainer.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants