Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't highlight colons (:) in comments #10014

Merged
merged 1 commit into from
Mar 27, 2024

Conversation

cotneit
Copy link
Contributor

@cotneit cotneit commented Mar 26, 2024

Since #9253 landed, ( ) and : are always highlighted in comments.

( ) highlighting was resolved in #9800, this PR removes : highlighting.

I imagine there are cases where we would like : to be highlighted, e.g. TODO:, but I have no idea what I'm doing, so in the meantime I think highlighting nothing is better than highlighting everything, especially when it comes to themes where it really stands out (in this case, noctis)

image_2024-03-26_16-58-04
image

@the-mikedavis the-mikedavis added S-waiting-on-review Status: Awaiting review from a maintainer. A-language-support Area: Support for programming/text languages labels Mar 27, 2024
@pascalkuthe pascalkuthe merged commit f21efc7 into helix-editor:master Mar 27, 2024
6 checks passed
postsolar pushed a commit to postsolar/helix that referenced this pull request Apr 4, 2024
postsolar pushed a commit to postsolar/helix that referenced this pull request Apr 4, 2024
postsolar pushed a commit to postsolar/helix that referenced this pull request Apr 4, 2024
postsolar pushed a commit to postsolar/helix that referenced this pull request Apr 20, 2024
mtoohey31 pushed a commit to mtoohey31/helix that referenced this pull request Jun 2, 2024
Vulpesx pushed a commit to Vulpesx/helix that referenced this pull request Jun 7, 2024
smortime pushed a commit to smortime/helix that referenced this pull request Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-language-support Area: Support for programming/text languages S-waiting-on-review Status: Awaiting review from a maintainer.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants