Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rustc warnings about unused 'pub use's #10011

Merged
merged 1 commit into from
Mar 27, 2024
Merged

Conversation

the-mikedavis
Copy link
Member

Newer rustc versions warn about these unused exports. On rustc 1.76.0 for example:

warning: unused import: `helix_view::handlers::lsp::SignatureHelpInvoked`
  --> helix-term/src/handlers.rs:12:9
   |
12 | pub use helix_view::handlers::lsp::SignatureHelpInvoked;
   |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |
   = note: `#[warn(unused_imports)]` on by default

warning: unused import: `keymap::macros::*`
  --> helix-term/src/lib.rs:23:9
   |
23 | pub use keymap::macros::*;
   |         ^^^^^^^^^^^^^^^^^

warning: `helix-term` (lib) generated 2 warnings (run `cargo fix --lib -p helix-term` to apply 2 suggestions)

@the-mikedavis the-mikedavis added E-easy Call for participation: Experience needed to fix: Easy / not much S-waiting-on-review Status: Awaiting review from a maintainer. labels Mar 26, 2024
@archseer archseer merged commit cb286b7 into master Mar 27, 2024
6 checks passed
@archseer archseer deleted the fix-new-rustc-warnings branch March 27, 2024 05:34
postsolar pushed a commit to postsolar/helix that referenced this pull request Apr 4, 2024
postsolar pushed a commit to postsolar/helix that referenced this pull request Apr 4, 2024
postsolar pushed a commit to postsolar/helix that referenced this pull request Apr 4, 2024
postsolar pushed a commit to postsolar/helix that referenced this pull request Apr 20, 2024
mtoohey31 pushed a commit to mtoohey31/helix that referenced this pull request Jun 2, 2024
Vulpesx pushed a commit to Vulpesx/helix that referenced this pull request Jun 7, 2024
smortime pushed a commit to smortime/helix that referenced this pull request Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
E-easy Call for participation: Experience needed to fix: Easy / not much S-waiting-on-review Status: Awaiting review from a maintainer.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants