Revert allowing backspace to close empty prompts #10005
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the-mikedavis
added
the
S-waiting-on-review
pascalkuthe
approved these changes
Mar 25, 2024
postsolar
pushed a commit
to postsolar/helix
that referenced
this pull request
Apr 4, 2024
…ix-editor#9828)" (helix-editor#10005) This reverts commit 0dc67ff. See the post-merge discussion in helix-editor#9828. The old behavior was less surprising and we have other ways to abort from a prompt, so let's revert the behavior change.
postsolar
pushed a commit
to postsolar/helix
that referenced
this pull request
Apr 4, 2024
…ix-editor#9828)" (helix-editor#10005) This reverts commit 0dc67ff. See the post-merge discussion in helix-editor#9828. The old behavior was less surprising and we have other ways to abort from a prompt, so let's revert the behavior change.
postsolar
pushed a commit
to postsolar/helix
that referenced
this pull request
Apr 4, 2024
…ix-editor#9828)" (helix-editor#10005) This reverts commit 0dc67ff. See the post-merge discussion in helix-editor#9828. The old behavior was less surprising and we have other ways to abort from a prompt, so let's revert the behavior change.
postsolar
pushed a commit
to postsolar/helix
that referenced
this pull request
Apr 20, 2024
…ix-editor#9828)" (helix-editor#10005) This reverts commit 0dc67ff. See the post-merge discussion in helix-editor#9828. The old behavior was less surprising and we have other ways to abort from a prompt, so let's revert the behavior change.
mtoohey31
pushed a commit
to mtoohey31/helix
that referenced
this pull request
Jun 2, 2024
…ix-editor#9828)" (helix-editor#10005) This reverts commit 0dc67ff. See the post-merge discussion in helix-editor#9828. The old behavior was less surprising and we have other ways to abort from a prompt, so let's revert the behavior change.
Vulpesx
pushed a commit
to Vulpesx/helix
that referenced
this pull request
Jun 7, 2024
…ix-editor#9828)" (helix-editor#10005) This reverts commit 0dc67ff. See the post-merge discussion in helix-editor#9828. The old behavior was less surprising and we have other ways to abort from a prompt, so let's revert the behavior change.
smortime
pushed a commit
to smortime/helix
that referenced
this pull request
Jul 10, 2024
…ix-editor#9828)" (helix-editor#10005) This reverts commit 0dc67ff. See the post-merge discussion in helix-editor#9828. The old behavior was less surprising and we have other ways to abort from a prompt, so let's revert the behavior change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 0dc67ff / #9828.
See the post-merge discussion in #9828. The old behavior was less surprising and we have other ways to abort from a prompt, so let's revert the behavior change.