-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCaml comment highlight is broken #9771
Comments
The rest of the content is grey, but |
I have seen this too, I would clarify the comment is orange/yellow only the leading bracket is gray, the leading bracket and the comment should all be the same color, one thing I notice is this seems to be regression since the previous release |
From a discussion on Element this seems to be an issue across all languages. Introduced here: |
Fixed in #9800 helix/runtime/queries/comment/highlights.scm Lines 1 to 4 in cc43e35
Is no longer needed. |
…tor#9800) * fix: close helix-editor#9771 update OCaml * fix: no longer match on ( ) as the underlying grammar handles these * fix: implement excellent corrections from review * fix: module -> namespace to match theme scopes
…tor#9800) * fix: close helix-editor#9771 update OCaml * fix: no longer match on ( ) as the underlying grammar handles these * fix: implement excellent corrections from review * fix: module -> namespace to match theme scopes
…tor#9800) * fix: close helix-editor#9771 update OCaml * fix: no longer match on ( ) as the underlying grammar handles these * fix: implement excellent corrections from review * fix: module -> namespace to match theme scopes
…tor#9800) * fix: close helix-editor#9771 update OCaml * fix: no longer match on ( ) as the underlying grammar handles these * fix: implement excellent corrections from review * fix: module -> namespace to match theme scopes
Summary
Reproduction Steps
Open an OCaml source file with comments and notice that instead of the usual greyed out comment, the first bracket is tilted and the rest of the content is not grey.
Helix log
~/.cache/helix/helix.log
Platform
macOS
Terminal Emulator
iTerm
Installation Method
source
Helix Version
helix 23.10 (44db259)
The text was updated successfully, but these errors were encountered: