Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider using ruff-lsp instead of pylsp as the default language server for Python #5399

Closed
schneiderfelipe opened this issue Jan 4, 2023 · 5 comments
Labels
A-language-support Area: Support for programming/text languages C-enhancement Category: Improvements

Comments

@schneiderfelipe
Copy link
Contributor

It's my view that ruff-lsp can provide a nicer user experience than pylsp mostly because ruff is very fast (written in Rust), so why not switch to it by default? Configuration for Helix is available here.

@schneiderfelipe schneiderfelipe added the C-enhancement Category: Improvements label Jan 4, 2023
@kirawi kirawi added the A-language-support Area: Support for programming/text languages label Jan 4, 2023
@kirawi
Copy link
Member

kirawi commented Jan 4, 2023

Never heard about ruff before, cool!

@Ordoviz
Copy link
Contributor

Ordoviz commented Jan 6, 2023

It's not yet time to switch to ruff-lsp: it lacks basic features (such as "goto definition") and is meant to be used alongside another LSP. Also, pylsp recently gained support for ruff via a plugin.

@tmke8
Copy link

tmke8 commented Jan 7, 2023

To me, pyright is the obvious choice given that it's the default in VSCode. It's also the default in nvim-lspconfig: https://github.com/neovim/nvim-lspconfig#quickstart

@the-mikedavis
Copy link
Member

Adding alternate language server configs to the language server installation wiki seems like an easy win for this: https://github.com/helix-editor/helix/wiki/How-to-install-the-default-language-servers

For a similar case there's a deno config mentioned even though typescript-language-server is the default for JS/TS languages

@schneiderfelipe
Copy link
Contributor Author

Adding alternate language server configs to the language server installation wiki seems like an easy win for this: https://github.com/helix-editor/helix/wiki/How-to-install-the-default-language-servers

Excellent! I just did it.

It's not yet time to switch to ruff-lsp: it lacks basic features (such as "goto definition") and is meant to be used alongside another LSP. Also, pylsp recently gained support for ruff via a plugin.

I'll add some instructions on how to use python-lsp/python-lsp-ruff as well soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-language-support Area: Support for programming/text languages C-enhancement Category: Improvements
Projects
None yet
Development

No branches or pull requests

5 participants