Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support to ignore .svn folder #2406

Closed
Bashe opened this issue May 5, 2022 · 4 comments · Fixed by #10536
Closed

Add support to ignore .svn folder #2406

Bashe opened this issue May 5, 2022 · 4 comments · Fixed by #10536
Labels
C-enhancement Category: Improvements E-good-first-issue Call for participation: Issues suitable for new contributors E-help-wanted Call for participation: Extra attention is needed

Comments

@Bashe
Copy link

Bashe commented May 5, 2022

Can you extend the ignore support to include ".svn" as well in addition to ".git" Actually when I think, maybe also ".hg"?

Thanks in advance!

@Bashe Bashe added the C-enhancement Category: Improvements label May 5, 2022
@archseer
Copy link
Member

archseer commented May 5, 2022

You can add those in your global .ignore file. https://docs.rs/ignore/0.1.6/ignore/struct.WalkBuilder.html#ignore-rules

@pickfire pickfire added the E-help-wanted Call for participation: Extra attention is needed label May 9, 2022
@pickfire
Copy link
Contributor

pickfire commented May 9, 2022

.ignore seemed like a temporary solution but I also wonder if it is worth maintaining a separate .svn ignore given that its popularity is far from git, but if someone do send a pull request I wouldn't mind helping to do a review.

@kirawi
Copy link
Member

kirawi commented May 15, 2022

If there's an effort made into supporting it, maybe it would be better to add it to ignore.

@pascalkuthe pascalkuthe added the E-good-first-issue Call for participation: Issues suitable for new contributors label Apr 12, 2024
simrankedia added a commit to simrankedia/helix that referenced this issue Apr 21, 2024
simrankedia added a commit to simrankedia/helix that referenced this issue Apr 21, 2024
@simrankedia
Copy link
Contributor

@pascalkuthe Raised another PR - let me know if you have any feedback, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-enhancement Category: Improvements E-good-first-issue Call for participation: Issues suitable for new contributors E-help-wanted Call for participation: Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants