Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using LSP to rename could store history #10560

Closed
shaleh opened this issue Apr 22, 2024 · 1 comment · Fixed by #10932
Closed

Using LSP to rename could store history #10560

shaleh opened this issue Apr 22, 2024 · 1 comment · Fixed by #10932
Labels
A-language-server Area: Language server client C-enhancement Category: Improvements E-has-instructions Call for participation: Has instructions for fixing the issue and opening a PR

Comments

@shaleh
Copy link
Contributor

shaleh commented Apr 22, 2024

When using -r to LSP rename things the previous names used are not remembered. Adding a register here would be more ergonomic. I was just fixing some unit tests in another project and had to rename the same name in multiple function in multiple files. Since there was no shared scope the LSP was not too helpful. Being able to pull up recent renames would make this refactoring work easier. Either the existing ':' used for other history or perhaps another register dedicated to this? I am using semicolon in code locally. Happy to post a tiny PR if we can agree on the register to use.

@shaleh shaleh added the C-enhancement Category: Improvements label Apr 22, 2024
@pascalkuthe
Copy link
Member

I discussed this with @the-mikedavis. We don't really want to add an new hardcoded register for every prompt. But it would be useful to add the ability to specify a register with " yourself (you can already do that for other prompts that do have a history so it would just be a matter of respecting register even if no default history is specified). That would allow you to hardcode a register in your config and would also allow more ergonomic pasing with ""<space>r

@pascalkuthe pascalkuthe added A-language-server Area: Language server client E-has-instructions Call for participation: Has instructions for fixing the issue and opening a PR labels Apr 28, 2024
sebastianpoeplau added a commit to sebastianpoeplau/helix that referenced this issue Jun 11, 2024
sebastianpoeplau added a commit to sebastianpoeplau/helix that referenced this issue Jun 11, 2024
Fix helix-editor#10560 by accepting an optional history register for the
rename_symbol command.
pascalkuthe pushed a commit that referenced this issue Jun 12, 2024
Fix #10560 by accepting an optional history register for the
rename_symbol command.
mxxntype pushed a commit to mxxntype/helix that referenced this issue Jun 12, 2024
Fix helix-editor#10560 by accepting an optional history register for the
rename_symbol command.
AOx0 pushed a commit to AOx0/helix that referenced this issue Jun 15, 2024
Fix helix-editor#10560 by accepting an optional history register for the
rename_symbol command.
smortime pushed a commit to smortime/helix that referenced this issue Jul 10, 2024
Fix helix-editor#10560 by accepting an optional history register for the
rename_symbol command.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-language-server Area: Language server client C-enhancement Category: Improvements E-has-instructions Call for participation: Has instructions for fixing the issue and opening a PR
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants