Use open crate to implement showing external documents

helix-editor · Feb 22, 2023 · 8a5aa67 · 8a5aa67
1 parent bb05b70
commit 8a5aa67
Show file tree

Hide file tree

Showing 3 changed files with 29 additions and 2 deletions.
diff --git a/Cargo.lock b/Cargo.lock
diff --git a/helix-term/Cargo.toml b/helix-term/Cargo.toml
@@ -38,6 +38,7 @@ anyhow = "1"
 once_cell = "1.17"
 
 which = "4.4"
+open = "3.2.0"
 
 tokio = { version = "1", features = ["rt", "rt-multi-thread", "io-util", "io-std", "time", "process", "macros", "fs", "parking_lot"] }
 tui = { path = "../helix-tui", package = "helix-tui", default-features = false, features = ["crossterm"] }

diff --git a/helix-term/src/application.rs b/helix-term/src/application.rs
@@ -1045,8 +1045,17 @@ impl Application {
                         use helix_view::editor::Action;
 
                         if params.external.unwrap_or(false) {
-                            // TODO: Implement this
-                            Ok(json!(lsp::ShowDocumentResult { success: false }))
+                            match open::that(params.uri.as_str()) {
+                                Ok(_) => Ok(json!(lsp::ShowDocumentResult { success: true })),
+                                Err(err) => {
+                                    let err = format!(
+                                        "failed to open path externally: {:?}: {:?}",
+                                        params.uri, err
+                                    );
+                                    self.editor.set_error(err);
+                                    Ok(json!(lsp::ShowDocumentResult { success: false }))
+                                }
+                            }
                         } else {
                             match params.uri.to_file_path() {
                                 Err(_) => {