alternate method of injecting the icon through a resource file, no ex…

…tra deps
helix-editor · Dec 17, 2023 · 69c9d6c · 69c9d6c
1 parent 3aaa895
commit 69c9d6c
Show file tree

Hide file tree

Showing 5 changed files with 7 additions and 33 deletions.
diff --git a/Cargo.lock b/Cargo.lock
diff --git a/contrib/helix-256p.ico → contrib/helix-icon-windows.lib b/contrib/helix-256p.ico → contrib/helix-icon-windows.lib
diff --git a/contrib/helix-windows.rc b/contrib/helix-windows.rc
@@ -0,0 +1 @@
+APPICON ICON helix256p.ico
diff --git a/helix-term/Cargo.toml b/helix-term/Cargo.toml
@@ -81,10 +81,6 @@ crossterm = { version = "0.27", features = ["event-stream", "use-dev-tty"] }
 [build-dependencies]
 helix-loader = { path = "../helix-loader" }
 
-[target.'cfg(windows)'.build-dependencies]
-# winres to inject icon into Windows binary
-winres = "0.1.12"
-
 [dev-dependencies]
 smallvec = "1.11"
 indoc = "2.0.4"

diff --git a/helix-term/build.rs b/helix-term/build.rs
@@ -1,5 +1,3 @@
-extern crate winres;
-
 use helix_loader::grammar::{build_grammars, fetch_grammars};
 
 fn main() {
@@ -9,8 +7,6 @@ fn main() {
             .expect("Failed to compile tree-sitter grammars");
     }
     if cfg!(target_os = "windows") {
-        let mut res = winres::WindowsResource::new();
-        res.set_icon("../contrib/helix-256p.ico");
-        res.compile().unwrap();
+        println!("cargo:rustc-link-lib=./contrib/helix-icon-windows");
     }
 }