lsp: Support insertReplace

Fixes #4473
helix-editor · Nov 8, 2022 · 1312682 · 1312682
1 parent 188aff0
commit 1312682
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/helix-lsp/src/client.rs b/helix-lsp/src/client.rs
@@ -311,6 +311,7 @@ impl Client {
                                     String::from("additionalTextEdits"),
                                 ],
                             }),
+                            insert_replace_support: Some(true),
                             ..Default::default()
                         }),
                         completion_item_kind: Some(lsp::CompletionItemKindCapability {

diff --git a/helix-term/src/ui/completion.rs b/helix-term/src/ui/completion.rs
@@ -113,7 +113,8 @@ impl Completion {
                     let edit = match edit {
                         lsp::CompletionTextEdit::Edit(edit) => edit.clone(),
                         lsp::CompletionTextEdit::InsertAndReplace(item) => {
-                            unimplemented!("completion: insert_and_replace {:?}", item)
+                            // TODO: support using "insert" instead of "replace" via user config
+                            lsp::TextEdit::new(item.replace, item.new_text.clone())
                         }
                     };