Skip to content

Commit

Permalink
Decrement self.current while popping from front
Browse files Browse the repository at this point in the history
  • Loading branch information
thomasschafer committed Jun 15, 2024
1 parent 6524d5f commit 12f8df1
Showing 1 changed file with 5 additions and 9 deletions.
14 changes: 5 additions & 9 deletions helix-view/src/view.rs
Original file line number Diff line number Diff line change
Expand Up @@ -38,22 +38,19 @@ impl JumpList {
Self { jumps, current: 0 }
}

// Returns the number of elements removed from the start
pub fn push(&mut self, jump: Jump) -> usize {
let mut num_removed = 0;
pub fn push(&mut self, jump: Jump) {
// don't push duplicates
if self.jumps.back() != Some(&jump) {
// If the jumplist is full, drop the oldest items until we have space for another addition.
for _ in 0..((self.jumps.len() + 1).saturating_sub(JUMP_LIST_CAPACITY)) {
if self.jumps.pop_front().is_some() {
num_removed += 1;
self.current = self.current.saturating_sub(1);
}
}

self.jumps.push_back(jump);
}
self.current = self.jumps.len();
num_removed
}

pub fn forward(&mut self, count: usize) -> Option<&Jump> {
Expand All @@ -67,13 +64,12 @@ impl JumpList {

// Taking view and doc to prevent unnecessary cloning when jump is not required.
pub fn backward(&mut self, view_id: ViewId, doc: &mut Document, count: usize) -> Option<&Jump> {
if let Some(mut current) = self.current.checked_sub(count) {
if let Some(current) = self.current.checked_sub(count) {
self.current = current;
let cur_jump = (doc.id(), doc.selection(view_id).clone());
if self.current == self.jumps.len() {
let num_removed = self.push(cur_jump.clone());
current = current.saturating_sub(num_removed);
self.push(cur_jump.clone());
}
self.current = current;
self.jumps.get(self.current).and_then(|next_jump| {
if next_jump == &cur_jump {
self.current -= 1;
Expand Down

0 comments on commit 12f8df1

Please sign in to comment.