Enhance database environment variable injection in Deployment#67
Merged
Conversation
- Updated the `InjectDatabaseEnvVars` function to include DB_NAME and DATABASE_URL environment variables. - Introduced a new helper function `connectionURLTemplateForDBType` to manage database URL templates based on the database type. - Added tests to verify the correct injection of new environment variables and their values. - Refactored existing tests to accommodate the changes in environment variable handling.
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
nghiaz160904
approved these changes
Apr 12, 2026
NgocAnhDo26
merged commit 7cf6573
into
features/sprint4-backend-templates-db-injection
5 checks passed
NgocAnhDo26
deleted the
users/dtna/issue-60/inject-formatted-db-connection-strings
branch
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enhance database environment variable injection in Deployment
InjectDatabaseEnvVarsfunction to includeDB_NAMEandDATABASE_URLenvironment variables.