Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adopt MP metrics 5.1.2 #9446

Merged
merged 1 commit into from
Oct 29, 2024
Merged

Conversation

tjquinno
Copy link
Member

Description

Resolves #9264

MP Metrics released 5.1.2 today which resolves the backward-incompatible API change in the Snapshot abstract class.

This PR adopts MP Metrics 5.1.2 and adds a test class which extends Snapshot but purposely does not implement bucketValues to make sure the API is now backward-compatible.

Documentation

Bug fix; no doc impact.

Signed-off-by: Tim Quinn <[email protected]>
@tjquinno tjquinno self-assigned this Oct 29, 2024
@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Oct 29, 2024
@barchetta barchetta mentioned this pull request Oct 29, 2024
9 tasks
@tjquinno tjquinno merged commit 9af787f into helidon-io:main Oct 29, 2024
44 checks passed
@tjquinno tjquinno deleted the 4.x-adopt-mp-metrics-5.1.2 branch October 29, 2024 22:54
barchetta pushed a commit to barchetta/helidon that referenced this pull request Nov 4, 2024
barchetta added a commit that referenced this pull request Nov 4, 2024
Signed-off-by: Tim Quinn <[email protected]>
Co-authored-by: Tim Quinn <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4.1.x tracking issue - MP Metrics backward-incompatible change
2 participants