Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4.x: Add additional postgresql + hibernate native-image configuration #9393

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

tvallin
Copy link
Member

@tvallin tvallin commented Oct 15, 2024

Description

Fixes #9136

Additional classes are registered from graalvm-reachability-metadata repository.

Documentation

none

@tvallin tvallin added native-image 4.x Version 4.x labels Oct 15, 2024
@tvallin tvallin self-assigned this Oct 15, 2024
@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Oct 15, 2024
Copy link
Contributor

@romain-grecourt romain-grecourt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would like to start using strict rules for mirroring the reflection config from graalvm-reachability-metadata for certain components:

  • We only use META-INF/native-image/groupId/artifactId/reflect-config.json
  • We DO NOT use META-INF/helidon/native-image/reflection-config.json

We will maintain an exact copy of the reflection config from graalvm-reachability-metadata under META-INF/native-image/groupId/artifactId/reflect-config.json.

If the versions supported in graalvm-reachability-metadata and in Helidon are different, we may add additional reflection config.

Ideally we should find a way to use a different file to make it easy to mirror. E.g. use native-image.properties to specify an additional file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4.x Version 4.x native-image OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[4.1.0] Hibernate Native image won't run with PostgreSQL
2 participants