Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Saving the Main Mapping does not inactivate the "Save" Button #332

Closed
vonglan opened this issue Apr 21, 2021 · 6 comments
Closed

Saving the Main Mapping does not inactivate the "Save" Button #332

vonglan opened this issue Apr 21, 2021 · 6 comments
Labels
enhancement New feature or request high priority realearn Related to ReaLearn

Comments

@vonglan
Copy link

vonglan commented Apr 21, 2021

Worked before.
Maybe something to do with the GUI hiding mechanism?

Clipboard.txt
Presets.zip

@vonglan
Copy link
Author

vonglan commented Apr 21, 2021

While researching the JSON for another question, I noticed that sometimes there are lines
"oscArgIndex": 0
in JSON, sometimes not. Might have something to do with it (I do not use OSC).

@helgoboss
Copy link
Owner

Can't reproduce.

The oscArgIndex is normal. ReaLearn saves every setting which doesn't correspond to some internal default. Doesn't have any influence.

@helgoboss helgoboss added the need more info Further information is requested label Apr 26, 2021
@vonglan
Copy link
Author

vonglan commented Apr 26, 2021

Can't reproduce it now either. But it was definitely happening.

@vonglan vonglan closed this as completed Apr 26, 2021
@vonglan
Copy link
Author

vonglan commented May 3, 2021

Just observing that again. I made a diff on the main mappings from preset vs. main mappings from exported clipboard.
This is the difference:

clipboard has:

         "fxAnchor": "id",
         "fxIndex": 1,
         "fxGUID": "527318EF-CAE5-2846-B246-D47B93945D20",

main mapping preset has:

         "fxAnchor": "focused",

@helgoboss
Copy link
Owner

Finally I know what you mean. You are thinking the "conversion to project-independent mappings" happens on the current mappings. But it doesn't. It's only done for the preset. Hence, the current mappings deviate from the ones in the preset. Although working exactly as intended, I see that this can raise confusion. Probably I will apply the conversion to the current mappings as well.

@vonglan
Copy link
Author

vonglan commented May 4, 2021

I have some thoughts about the FX selection defaults, will open a separate Issue as suggestion (could also be opened under "discussion", but there is so little traffic there I think it makes more sense here)

@helgoboss helgoboss added enhancement New feature or request high priority and removed low priority need more info Further information is requested labels May 16, 2021
helgoboss added a commit that referenced this issue May 18, 2021
by applying project independence transformation onto current mappings, not
just the ones in the preset itself
@helgoboss helgoboss added the realearn Related to ReaLearn label Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request high priority realearn Related to ReaLearn
Projects
None yet
Development

No branches or pull requests

2 participants