Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Playtime: Various issues when using time signatures with non-4 denominator #1223

Closed
5 tasks done
helgoboss opened this issue Sep 23, 2024 · 0 comments
Closed
5 tasks done
Labels
bug Something isn't working playtime Related to Playtime
Milestone

Comments

@helgoboss
Copy link
Owner

helgoboss commented Sep 23, 2024

  • Metronome beats in quarter notes only (should beat according to the time signature numerator)
  • Stop scheduling doesn't work accurately anymore
  • Playtime GUI shows countdown as quarter notes instead of beats
  • Writing to arrangement
  • Tap tempo when stopped
@helgoboss helgoboss added bug Something isn't working playtime Related to Playtime labels Sep 23, 2024
@helgoboss helgoboss added this to the 2.16.9 milestone Sep 23, 2024
@helgoboss helgoboss changed the title Playtime: Wrong behavior and metronome when using time signatures with denominator != 4 Playtime: Wrong behavior/metronome when using time signatures with denominator not 4 Sep 23, 2024
@helgoboss helgoboss changed the title Playtime: Wrong behavior/metronome when using time signatures with denominator not 4 Playtime: Wrong behavior/metronome when using time signatures with non-4 denominator Sep 23, 2024
@helgoboss helgoboss moved this to In Progress in Helgobox Development Sep 23, 2024
@helgoboss helgoboss changed the title Playtime: Wrong behavior/metronome when using time signatures with non-4 denominator Playtime: Various issues when using time signatures with non-4 denominator Sep 23, 2024
helgoboss added a commit that referenced this issue Sep 24, 2024
- Fix tempo tapping and count-in recordings with non-4 denominators
- Make tempo tapping and silence mode actions real-time-capable
- Refactor tempo tapping and silence mode logic to be real-time first and have less code duplication
@github-project-automation github-project-automation bot moved this from In Progress to Done in Helgobox Development Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working playtime Related to Playtime
Projects
Archived in project
Development

No branches or pull requests

1 participant