Skip to content

Very hard to make a text field lose focus #1213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
JackOrez opened this issue Sep 20, 2024 · 3 comments
Closed

Very hard to make a text field lose focus #1213

JackOrez opened this issue Sep 20, 2024 · 3 comments
Labels
bug Something isn't working realearn Related to ReaLearn
Milestone

Comments

@JackOrez
Copy link

Bug #2:
Could possibly be related to this?

In versions prior to 2.16.4, I could enter text into any text input field in Helgobox and then just click any of it's title bar's to release focus,
however now I have to click 'OK' to exit the 'Mapping' page or click completly outside of Helgobox to release the focus.

This is also problematic on the main page, for example if you click the VST preset dropdown and then try to release focus by clicking
the title bar, the dropdown will close but it still has focus.[Not good if you have mappings that use Computer Keyboard as input and presets names
that start with that key.] By the way, is there some technical reason why the user can't just click an empty spot within the UI in order to
release focus from controls?

@helgoboss helgoboss added bug Something isn't working realearn Related to ReaLearn labels Sep 22, 2024
@helgoboss helgoboss added this to the 2.16.9 milestone Sep 22, 2024
@helgoboss
Copy link
Owner

I just tried this on macOS. The focus behavior didn't change there:

  • Clicking the title bar doesn't make the text field lose focus
  • Clicking on some other UI elements (but not all) makes the text field lose focus
  • Pressing TAB or ENTER makes the text field lose focus. In a mapping panel, ENTER also closes the mapping panel.

When using keyboard sources with REAPER 7.23+, not making the text field lose focus will prevent the source from learning/firing, so there's that. But I think you didn't run into that yet.

But I know you use Windows. Trying that next.

@helgoboss
Copy link
Owner

I also tried on Windows. The focus behavior didn't change between 2.16.3 and 2.16.4 there either. Result:

  • Clicking the title bar doesn't make the text field lose focus
  • Clicking on some other UI elements (but only active ones, it seems) makes the text field lose focus
  • Pressing TAB or ENTER doesn't have any effect

Okay, that is bad. But it didn't seem to change within ReaLearn. I also tried with an older REAPER version (7.17) and it still has this bad behavior. Maybe a Windows update?

I'll try to make it work at least with TAB or ENTER. This is what I always used.

@helgoboss
Copy link
Owner

I implemented the following:

  • Windows: TAB will change focus again (as on macOS, turns out this was broken already a long time on Windows, since the introduction of Pot Browser)
  • Prevent closing of mapping panel when pressing enter

@github-project-automation github-project-automation bot moved this from In Progress to Done in Helgobox Development Sep 25, 2024
@helgoboss helgoboss changed the title UI Bug #2 Very hard to make a text field lose focus Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working realearn Related to ReaLearn
Projects
Archived in project
Development

No branches or pull requests

2 participants