Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Playtime: Enabling/disabling FX with PDC while REAPER is stopped totally destroys timing #1164

Closed
helgoboss opened this issue Sep 3, 2024 · 4 comments
Labels
bug Something isn't working playtime Related to Playtime
Milestone

Comments

@helgoboss
Copy link
Owner

helgoboss commented Sep 3, 2024

The following can be observed when having latency-heavy FX on the master FX chain. This issue is PDC-related.

Can easily be tested by putting ReaFir on the master track with a huge FFT size (e.g. 32768).

Enabling/disabling such FX while just Playtime is playing, leads to loss of timing

This should ideally be fixed by using a form of resyncing (by tracking a hypothetical playback position).

#1180 is similar but is about the case that REAPER transport is running.

@helgoboss helgoboss added bug Something isn't working playtime Related to Playtime labels Sep 3, 2024
helgoboss added a commit that referenced this issue Sep 6, 2024
helgoboss added a commit that referenced this issue Sep 8, 2024
and resync to it on PDC changes
@helgoboss helgoboss added this to the 2.16.4 milestone Sep 9, 2024
helgoboss added a commit that referenced this issue Sep 9, 2024
@helgoboss helgoboss changed the title Playtime: Enabling/disabling FX with PDC can cause weird behavior Playtime: Enabling/disabling FX with PDC while REAPER is stopped totally destroys timing Sep 9, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Done in Helgobox Development Sep 9, 2024
@jimmydeer
Copy link

jimmydeer commented Sep 9, 2024 via email

@helgoboss
Copy link
Owner Author

Hi Jimmy.

For now, this only fixes the issue while REAPER is stopped.

#1180 will take care of the case when REAPER is playing. This won't be part of the 2.16.4 release.

@jimmydeer
Copy link

jimmydeer commented Sep 10, 2024 via email

@helgoboss
Copy link
Owner Author

Note: Timing issues can still occur. It just got a bit better than before. Might improve that in the future step by step. We will see what are the natural limits here. Changing PDC during a live session while things are still playing is not a good idea anyway, in no DAW. It will most likely lead to clicks and stuff.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working playtime Related to Playtime
Projects
Archived in project
Development

No branches or pull requests

2 participants