Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ReaLearn: Timing information not passed on when translating device MIDI to device MIDI #1162

Closed
helgoboss opened this issue Sep 2, 2024 · 0 comments
Closed

ReaLearn: Timing information not passed on when translating device MIDI to device MIDI #1162

helgoboss opened this issue Sep 2, 2024 · 0 comments
Labels
bug Something isn't working realearn Related to ReaLearn
Milestone
2.16.4

Comments

@helgoboss
Copy link
Owner

helgoboss commented Sep 2, 2024 •
edited
Loading

https://forum.cockos.com/newreply.php?p=2806396

Error probably here: https://github.com/helgoboss/realearn/blob/f6df8e2ce6408b513b0477aa69ec8ff2536f3531/main/src/domain/targets/midi_send_target.rs#L130-L130 (should not be Instantly).

Asked Justin already why there are 2 frame offsets (one in the event and one in the parameter) and which one is the important one. Probably the parameter.
@helgoboss helgoboss added bug Something isn't working realearn Related to ReaLearn labels Sep 2, 2024
@helgoboss helgoboss added this to the 2.16.4 milestone Sep 2, 2024
@helgoboss helgoboss moved this from Todo to In Progress in Helgobox Development Sep 3, 2024
helgoboss added a commit that referenced this issue Sep 3, 2024
@helgoboss
#1162 Pass timing information on when sending from device MIDI to dev…
cee7b55 
…ice MIDI
@github-project-automation github-project-automation bot moved this from In Progress to Done in Helgobox Development Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working realearn Related to ReaLearn
Projects
Helgobox Development
Status: Done
Milestone
2.16.4
Development

No branches or pull requests
1 participant
@helgoboss